--- Tomas Frydrych <[EMAIL PROTECTED]> wrote: > > ispell_checker.cpp: initialized all member pointers > to NULL and iconv handles to -1 (to stop deleting > things we never allocated). This needs to be ported > to STABLE.
Actually there is a value such as ICONV_INVALID which we should use instead of -1. I'll check this. > xap_Win32FrameImpl.cpp: added further processing of > WM_INPUTLANGCHANGE message so that change of > keyboard layout automatically changes langauge at > insertion point in the active window. This is very cool but we really should watch out for changing the language too often. We will end up with lots of messy language tags like MS Word documents do. We probably shouldn't actually change the language until the user starts typing with the new keyboard, until that it should just be a "pending" language change. Maybe your implementation works this way anyway. The other thing is that changing keyboard layouts does not necessarily mean you want to change the language. I change layouts every day just to access accented characters for instance. For this reason, "Autmotic language change with keyboard change" should be an option - like it is in MS Word. One other thing to watch out for is that the same layout may be used for more than one language, or for two versions of the same language - I'm not sure what the best thing to do in this case is. Just making sure we're all aware of the corner cases... Andrew Dunbar. > ap_EditMethods.cpp: fixed a bug in the "language" > method > > Tomas ===== http://linguaphile.sourceforge.net/cgi-bin/translator.pl http://www.abisource.com __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com
