Sergio Berna wrote:
In fact I introduced them there first, but while modifying
DaoAuthenticationProvider I realized that if people simply changed the
acegi jar on their respective installations they would get a
NoSuchMethodException and would be forced to modify their code
implementing the 2 new methods. That's why I introduced the interface, so
that I could check wheter UserDetails was extended with expiration
information before calling the methods.
I wouldn't worry too much about that one Sergio, as we've got an
established history of providing an upgrade-x-x file with each formal
release. These files prompt people to make the required changes. You can
see the past and present upgrade files at
http://acegisecurity.sourceforge.net. We'll just profile the change in
there.
Anyway, I'll perform all the modifications requested for the methods and
UserDetails inclusion and will also modify the existing UserDetails
implementations (User) as you suggest. I will also modify existing test
cases for UserDetails so that it includes both expiration checks and the
corresponding doc.
That will be great. Would you also mind taking a look at the
PasswordDaoAuthenticationProvider, as it is very similar to
DaoAuthenticationProvider and probably should also support the same changes.
Thanks for your effort on this improvement.
Ben
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Home: http://acegisecurity.sourceforge.net
Acegisecurity-developer mailing list
Acegisecurity-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
