Ben, Yes, sorry I wasn't clear on which class. I meant the AclDetailsHolder in the JdbcDaoImpl. I've been forced to fork off the JdbcDaoImpl code into my own classes completely here due to the fact that they're rather hard to extend if you want to do more than just tweak the query strings. One of the issues I ran into was that AclDetailsHolder and other internal classes make it difficult to extend because the code apparently still calls the original implementations, not my implementations, and there doesn't seem to be a clean way to hook into my own classes.
Although I really have just started working on this stuff for a few days, and I would need to work with it some more to formulate some suggestions on how to make them more easily extensible. But changing the values to long would be a good start. I would submit a patch, but Sourceforge's CVS still is not working for me at the moment. I'll file a JIRA issue on it. -tim -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ben Alex Sent: Sunday, August 21, 2005 6:14 AM To: acegisecurity-developer@lists.sourceforge.net Subject: Re: [Acegisecurity-developer] using long for acegi acl id parameters Tim Kettering wrote: > I'm wondering if there was a reason that most of Acegi's standard ACL > classes use int when dealing with object id values. We usually default > to using 'long' instead of 'int' - and I believe that other places do > as well, so it seems to me that it might be simpler to use 'long' in > the acegi classes, since the java compiler can automatically cast int > to long anyway. > Hi Tim Which ACL classes are you referring to? AbstractBasicAclEntry uses int because it performs bit masking which shouldn't need the full size of a long. If you mean AclDetailsHolder (protected class within JdbcDaoImpl) I see your point and we should change it. Please feel free to submit a patch or issue to JIRA and I'll get it done. Cheers Ben ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Home: http://acegisecurity.sourceforge.net Acegisecurity-developer mailing list Acegisecurity-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Home: http://acegisecurity.sourceforge.net Acegisecurity-developer mailing list Acegisecurity-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
