Hi Giulio,

first of all, thank you so much for your hard work.  It is appreciated.

Secondly, I think the proposed changes to the options are good, so from me it is a "go ahead" on the options.

Thirdly, I will try to make time for a code review of your changes, which might ferret out some bugs, so don't worry about that either.

In conclusion: From me, it is a "please go ahead".

Best wishes,

Ulrik Sandborg-Petersen



On 01/02/16 22:07, Giulio Paci wrote:

Hi to all,
   I am proceeding with my work trying to update acopost codebase.
I now have several commits that I would like to push, but I think we should agree on some of them before I proceed.

I have completed the work about readline replacement, so now there are just a few other functions that should be replaced with re-entrant alternatives (e.g.: strtok, lowercase, tokenizer, ...).

In the meanwhile I started rewriting option handling. I wrote a module that has been inspired by the glib one for option handling, that improves readability very much. However this module enforces some common practice that introduces some incompatibilities (in particular it forces options to appear before file names) and I introduced some others in order to make the command lines interfaces more uniform: all commands should respect -h (help) and -v (verbosity level), when dictionary is needed -d should be used, -o is used for operation mode, accepting integers or names, always with the same meaning across binaries. I think the benefits of a common interface are better then perfect backward compatibility. However, before pushing it and before completing my job (met is still not updated, documentation is not updated as well), I would like to know if you think this work is useful or if you consider this change too intrusive.

I modified met so that now it uses malloced arrays (and do not crash anymore with my PC). Unfortunately it is very slow. I do not know if this was expected or if it is due to my changes.
I have made so many changes that I likely introduced several bugs.

I also tried to compile a list of my desiderata in a TODO file. I guess we could also add other items to that list (e.g.: make the tagger more generic).

What do you think about it? May I proceed?

Bests,
Giulio.



------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140


_______________________________________________
acopost-devel mailing list
acopost-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acopost-devel

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
acopost-devel mailing list
acopost-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acopost-devel

Reply via email to