http://bugzilla.kernel.org/show_bug.cgi?id=9487
------- Comment #27 from [EMAIL PROTECTED] 2008-01-17 16:00 ------- I have an issue with: if (data.irq.descriptor_length == ACPI_DESCRIPTOR_4_BYTES) If the field is named "length", I think that it should hold the actual length of the descriptor, not an encoded length. If the length is indeed a flag, the field should be: if (data.irq.flags & ACPI_DESCRIPTOR_4_BYTES) Otherwise, the name "length" is misleading and could lead to bugs later. The options for the StartDependentFunctions are length 0 and length 1, so it may be best to simply use the actual length, otherwise we end up with flags like this: ACPI_DESCRIPTOR_IRQ_3_BYTES ACPI_DESCRIPTOR_IRQ_4_BYTES ACPI_DESCRIPTOR_SDF_0_BYTES ACPI_DESCRIPTOR_SDF_1 BYTE -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
