http://bugzilla.kernel.org/show_bug.cgi?id=10658





------- Comment #69 from len.br...@intel.com  2009-02-25 14:46 -------
Martin, Matthew, Thomas,

Thank you for your tenacity.

I do now agree that it is worth the risk to try to deploy
this w/o DMI, for there will be other boxes like this one.

As Zhang-Rui poined out, I staged Matthew's latest patch
for 2.6.30.  Martin, hopefully your old laptop
is still available to test and benefit from this patch?

The main things I wonder about right now are:

1. is polling really necessary?
   The observation in comment #64 suggests that on this box
   it should not be necessary.  Notify(0x80) on the thermal zone
   is a thermal zone status change, which is exactly we should need
   to re-evaluate the temperature and compare to trip points.

   Martin, it would be interesting to discover at what temperature
   you start seeing these events.

2. observability
   We should probably print something when we manufacture a _PSV
   and we should occasionally print a warning when throttling is invoked.

   It is a risk that we may over-throttle and impact performance
   more than we need to.  Note that this will behave differently
   for the CPU_FREQ=y and n cases.  In the former, we try to exhaust
   the P-states before using T-states.  In the later, we run at HFM
   and use T-states from there.

3. default constants
   _TZP in the ACPI spec is defined to have a minimum value of 30 seconds.
   (and a maximum of 5 minutes).  We are defaulting to poll every 10 sec.
    and I wonder if that is it more often than necessary.  _TSP is basically
    a guess.  I don't have any better suggestions, but we should probably
    at least comment that these are guesses.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to