http://bugzilla.kernel.org/show_bug.cgi?id=12748





------- Comment #7 from h...@hmh.eng.br  2009-03-23 03:13 -------
Sure about it?  It will leak pointers like crazy until the rest of the code is
fixed...

What I did was just a revert for ff24ba74b6d3befbfbafa142582211b5a6095d45 and a
simple patch to always call the power resource setup, even if the device was
already at D0.   The revert is trivial (but must be done by hand because the
code changed a bit in that area).  The other part of it is just conceptual.

The complete fix would require:

1. A set of proper hooks for enable/disable device, that are **ALWAYS** called,
regardless of initial power state, and regardless of whether the underlying
code has been fixed to place devices back at D3 or not.

Without these hooks, we either fail to attach resources, or (MUCH WORSE) leak
resources and dangling pointers when devices are freed.

2. Using these hooks for power resource attach/detach.

3. Checking for any power resources that are enabled, but that have no users at
ACPI start (as well as power resources that are disabled, but DO have users) at
late suspend, early resume, and maybe other windows of opportunity.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to