http://bugzilla.kernel.org/show_bug.cgi?id=13389
--- Comment #1 from Frans Pop <elen...@planet.nl> 2009-05-26 18:52:18 ---
I just see that my analysis here is not complete.
> 3) The reset that is being done when the warning triggers is bogus for my
> case because in acpi_processor_set_throttling_ptc() it is ignored due to
> the following test:
> if (state == pr->throttling.state)
> return 0;
The problem is that the code creates a self-fulfilling prophesy.
In acpi_processor_get_throttling_ptc():
pr->throttling.state = 0;
[...]
state = acpi_get_throttling_state(pr, value);
if (state == -1) {
ACPI_WARNING((AE_INFO,
"Invalid throttling state, reset"));
state = 0;
ret = acpi_processor_set_throttling(pr, state);
So acpi_processor_get_throttling_ptc() sets both pr->throttling.state _and_
state to 0 before calling acpi_processor_set_throttling(). No wonder the test
there always succeeds and no change is actually made!
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
