http://bugzilla.kernel.org/show_bug.cgi?id=13389
--- Comment #2 from Frans Pop <elen...@planet.nl> 2009-05-31 21:11:14 --- Created an attachment (id=21671) --> (http://bugzilla.kernel.org/attachment.cgi?id=21671) Patch to force throttling reset In the attachment one possible patch to fix the problem that no reset to T0 actually takes place. I've tested it on my system and with that there remains only one reset message per processor (during boot). Because the reset now really does happen, the later warnings during 'cat /proc/acpi/processor/*/throttling' are gone. After this bug is fixed I don't have any real objection to changing the warning to debug level, as suggested by Zhang Rui in http://bugzilla.kernel.org/show_bug.cgi?id=13259#c29. The attached patch is straightforward, but fairly big. One much simpler solution could be the following patch: --- a/drivers/acpi/processor_throttling.c +++ b/drivers/acpi/processor_throttling.c @@ -842,6 +842,7 @@ static int acpi_processor_get_throttling_ptc( ACPI_WARNING((AE_INFO, "Invalid throttling state, reset\n")); state = 0; + pr->throttling.state = 9; /* Ensure reset happens */ ret = acpi_processor_set_throttling(pr, state); if (ret) return ret; Yet another approach could be to always initialize the throttling state to T0 in acpi_processor_get_throttling_info(), but that would still require the change to T0 to be forced somehow. Comments welcome. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are watching the assignee of the bug. ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
