https://bugzilla.kernel.org/show_bug.cgi?id=44161

--- Comment #131 from Juan Manuel Cabo <juanmanuel.c...@gmail.com> ---
(In reply to Dennis Jansen from comment #130)
> I can confirm this. Now we only have to turn this into a generic kernel
> patch. Does it always make sense to read the EC until it's empty? Could
> someone confirm this? Maybe this will fix other problems we were not even
> aware of?
> At least it seems the listed Samsung system should get a fix.

A proper fix would be to have some way to tell the EC to not accumulate events
during S3 sleep, failing that, running the loop right after suspend to empty
those useless events produced during sleep I think is the best option. A good
place to do that would be in <linuxkernel>/drivers/acpi/ec.c function
acpi_ec_unblock_transactions_early() or in some other function called from
sleep.c at resume.

The events accumulated during S3 sleep are useless, so it is does make sense to
clear them all. Again, the best fix would be to have a way to tell the EC not
to try to report events during sleep.

After all, the DSDT method _WAK() does Notify() whether the
batterycharge/AC/LID changed during sleep, and does this independently of the
EC.

--
Juan Manuel Cabo

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to