Le Monday 30 July 2007 11:21:31 Richard Hughes, vous avez écrit : > Hi, > > I've been converting the various acpi drivers to use the input subsystem > rather than using acpi events or other random proc interfaces. > > So far sony-laptop and thinkpad_acpi have been converted, and I would > like to also suggest asus-acpi does the same as well. > > Doing so have the following advantages: > > * we can get rid of vendor specific acpi event daemons that have to be > configured > * we can simplify and have one single reporting stack > * we can remap keys using the existing infrastructure at the quirk > pages: http://people.freedesktop.org/~hughsient/quirk/ > * the buttons "just work" without configuration > > I've attached a patch for review. I've compile tested it, but I haven't > got any asus hardware to test it on. Comments, suggestions and > criticisms welcome. > > Making asus acpi using input allows us to use HAL to report some > buttons, and eventually use a evdev X to automatically make buttons > work, no matter if they are on a true keyboard or acpi generated events. > > Thanks for review, > > Richard.
Hi, Thanks for your patch, I think it's a good idea, but you should send it to [EMAIL PROTECTED] to get more review on it =). Now that asus-laptop is in mainline I don't think that it's a good thing to maintain a lot of versions of asus-laptop ... -- CHARY 'Iksaif' Corentin http://xf.iksaif.net ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Acpi4asus-user mailing list Acpi4asus-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi4asus-user
