This assert verifies that the test has tested the situation it was supposed to test. It is a regression test in a situation where a user is not found, which used to cause a crash in sanitizer interceptor code.
Could you please check if this test passes without sanitizer? It's either getpwname_r not following the spec, or ASan changing it's behaviour. On Thu, Apr 2, 2015 at 7:18 PM, Renato Golin <[email protected]> wrote: > On 2 April 2015 at 17:14, Venkataramanan Kumar > <[email protected]> wrote: >> It also says under ERRORS >> (snip) >> 0 or ENOENT or ESRCH or EBADF or EPERM or ... >> The given name or uid was not found >> (snip) >> >> Looks like we can remove the assert. > > I think the bigger question is: what is this testing... > > Kostya, > > This test seems very fragile and possibly {platform+libc+OS}-specific. > Is there any other way of testing whatever it was without calling libc > functions? If that was testing the specific function, I'm not sure > those asserts will give you any indication of success, other than libc > execution tests, which ASAN is not the place to have. > > If the test is trying not to have any sanitizer crashes, than the > asserts are indeed useless. > > cheers, > --renato > > -- > You received this message because you are subscribed to the Google Groups > "address-sanitizer" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "address-sanitizer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
