+1 for initialValue, indeed its sound better than startValue +1 for visibleYearCount (none other got proposed but I find that one evocative enough)
+0.5 for the weekend. After reading both suggestions from Adam and Matthias and Simon, I would say that weekendDisable sounds ok. BUT there is also room to add something more that check for some more days to be disabled (holidays) which could be provided as small restrictives lists of others important days beside the normal weekend ones. (a validator or something that could be handled by the user) Some more comments inline too. [EMAIL PROTECTED] a écrit sur 2006-08-10 09:19:34 : > +1 for initialValue instead of startValue > +1 for visibleYearCount > > For weekends however I would prefer a validator over an attribute for the > inputDate component. > > Simon Lessard > Fujitsu Consulting > > "Adam Winer" <[EMAIL PROTECTED]> > 2006-08-10 00:17 > Please respond to adffaces-dev > > To: [email protected] > cc: > Subject: chooseDate/inputDate attribute names > > > There's a few outstanding JIRA requests for adding attributes > to the date components (chooseDate and inputDate): > > - "startValue": (from ADFFACES-90): pick the date that > should be selected when the chooseDate or inputDate > components first come up > - "visibleYearCount": (from ADFFACES-91): let you set the > number of years visible for one "block" of the dropdown > - "weekendSelectable": (from ADFFACES-92): let you > block weekends from being choseable > > So, the questions are: > 1. Whether these are desirable features? > 2. What names you'd like for these? > > To answer my own questions: > > > 1. Whether these are desirable features? > > +1 to 90 and 91; -0.5 to 92; it might > be better to let you enable/disable arbitrary days, > instead of just the weekend on-or-off. > > > 2. What names you'd like for these? > > Alternative names that come to mind: > - For ADFFACES-90: "initialValue" > - For ADFFACES-92: "weekendDisabled" 1 small thing, actually, its the opposite mentality that is coded, instead of weekendDisabled, the default value and such would provide the effect of "weekendEnabled" (that is, if not specifically set by the user, the value is 'true'). Should the patch be accepted, there will be a few places to invert both 'true' to 'false' and probably add a '! not' verification at one place. > > As a more general request, it'd be great if developers proposing > new features would bring it to the e-mail list before filing JIRA > issues and implementing patches. After going back to check the other post I made (see below), I guess yes, I hadn't really elaborated enough about the new feature I planned to add. Will be more explicit next time before starting something new. http://mail-archives.apache.org/mod_mbox/incubator-adffaces-dev/200607.mbox/browser > > Thanks, > Adam >
