Hello all,
I provided a patch for ADFFACES-121. However, I'm not totally satisfied
with it.
Before the patch, the code was only converting the urls of
background-image property when placed inside url( ). My patch converts all
values inside url( ) as well as background-image property value when not
placed inside url( ). For instance:
Skin:
background: url('images/myGif.gif');
background: images/myGif.gif;
background-image: url('images/myGif.gif');
background-image: images/myGif.gif;
Result with "MyApp" context root:
background: url('/MyApp/skins/mySkin/images/myGif.gif');
background: images/myGif.gif;
background-image: url('/MyApp/skins/mySkin/images/myGif.gif');
background-image: /MyApp/skins/mySkin/images/myGif.gif;
It's a kind of inconsistency that could mix the user I think. I therefore
see two possibilities:
1. Convert only but all values specified inside url( ), leaving others
unchanged.
2. Make sure the hard coded list of property names allowing property
values is exhaustive and document it accordingly.
Which one would be better? My vote goes to 1. since it will be easier to
document and maintain.
Regards,
Simon Lessard
Fujitsu Consulting
