Hi,
I have tested new faces-major FrameBorderLayoutRenderer, I have found some bugs
with this patch it works better for my pages:

Index: C:/dev/workspace_LWD/trinidad/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FrameBorderLayoutRenderer.java
===================================================================
--- C:/dev/workspace_LWD/trinidad/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FrameBorderLayoutRenderer.java (revision 432501) +++ C:/dev/workspace_LWD/trinidad/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FrameBorderLayoutRenderer.java (working copy)
@@ -187,10 +187,10 @@
          null);
      }
      writer.writeAttribute(XhtmlConstants.ROWS_ATTRIBUTE, sizes, null);
+ + _renderFrameBorderAndSpacing(writer, bean);
    }

-    _renderFrameBorderAndSpacing(writer, bean);
-
    _encodeFacet(context, top);

    // sizes is set to be
@@ -218,10 +218,10 @@
          null);
      }
      writer.writeAttribute(XhtmlConstants.COLS_ATTRIBUTE, sizes, null);
+ + _renderFrameBorderAndSpacing(writer, bean);
    }
-
-    _renderFrameBorderAndSpacing(writer, bean);
-
+ _encodeFacet(context, left);
    _encodeFacet(context, innerLeft);
    _encodeFacet(context, center);
@@ -242,12 +242,15 @@
      writer.endElement("frameset");
    }

-    writer.startElement("noframes", null);
+ UIComponent alternateContent = getFacet(component, HtmlFrameBorderLayout.ALTERNATE_CONTENT_FACET);
    if (alternateContent != null)
+    {
+ writer.startElement("noframes", null); encodeChild(context, alternateContent);
-    writer.endElement("noframes");
+      writer.endElement("noframes");
+    }

    writer.endElement("frameset");
  }


Arnaud

Reply via email to