Hey Bruno, great stuff!
Can we add this to the MyFaces-build somehow? I wonder how we will handle the problem of the two source-repositories. Will we add an external link to the generator-plugin? regards, Martin On 10/30/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
> Not yet. I am just testing with a small component. Now components > should be generated fine for myfaces. Tomorrow if I have time, I will that was your last commit, isn't it? > implement the tag generators. After that, the plugin branch should be > merged with the trinidad-1_2 branch, and then we can start rewriting > the xml files for the html components. let's test that intensive first ;) > > I have two days vacation in November, maybe I can help out on some > > stuff, like writing XML files ;) > > > Yes, thats the tedious part... yap! but compared what you do in "classic" JSF nice! I like the plugin for doing components. Glad you had time to do the "changes" to it! > > @Trinidad/Tomahawk: I don't mind to use the FacesBean approach for the > > Trinidad custom components; we also can look at the *optimized* client > > side state saving... > > but that is far away from now ;) > > > > you mean for the tomahawk custom components, right? Yes, that would be > easier once all components under the MyFaces umbrella are generated > the same way :) yes, also the FacesBean is better in performance for the getter/setter. The classic JSF getters look funny, isn't it? -M > > -M > > Bruno > > > > > On 10/29/06, Bruno Aranda <[EMAIL PROTECTED]> wrote: > > > Thanks Adam. I am refactoring the plugin so it can be extended easily. > > > Instead of putting "if" statements over and over again in the mojo (I > > > have started with that), I have decided to create a ComponentGenerator > > > interface, which can have different implementations (e.g. trinidad, > > > myfaces, and I guess tomahawk in the future...) depending on the > > > specific details of every component library. I will add a TagGenerator > > > too, to do the same with the tags. The plugin is excellent, the only > > > thing I am doing is refactoring things "a little" and adding the code > > > specific for myfaces core 1.2. > > > Maybe this plugin can help to reuse the same base classes for tomahawk > > > and trinidad in the future, > > > > > > Cheers, > > > > > > Bruno > > > > > > On 10/29/06, Adam Winer <[EMAIL PROTECTED]> wrote: > > > > Cool! (Glanced at what you're coding on that branch so far, looks > > > > excellent.) > > > > > > > > -- Adam > > > > > > > > > > > > On 10/28/06, Bruno Aranda <[EMAIL PROTECTED]> wrote: > > > > > > > > > > Ok, I will rebranch the branch to add the new features to be able to > > > > > use the plugin directly with myfaces and in the future to generate > > > > > also the tomahawk library. > > > > > > > > > > Bruno > > > > > > > > > > On 10/28/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > > > > The Mojo for the TagKlass files is working out of the box. > > > > > > Validators/Converters are not generated, but the plugins register > > > > > > them in faces-config.xml file > > > > > > > > > > > > do you have something working? > > > > > > Why not creating a branch in Trinidad for that ? > > > > > > I mean, you are a committer ;) > > > > > > > > > > > > > > > > > > > > > > > > On 10/28/06, Bruno Aranda <[EMAIL PROTECTED]> wrote: > > > > > > > Ah, and I forgot: > > > > > > > > > > > > > > d. Do not generate the protected constructor that accepts the > > > > > > > renderType as a parameter > > > > > > > > > > > > > > Cheers, > > > > > > > > > > > > > > Bruno > > > > > > > > > > > > > > On 10/28/06, Bruno Aranda <[EMAIL PROTECTED]> wrote: > > > > > > > > Ok, I have been playing with the maven-faces-plugin from the 1.2 > > > > > > > > branch to adapt it to generate the components for myfaces. > > > > > > > > > > > > > > > > What I have identified so far is: As the component superclass must > > > > > be > > > > > > > > javax.faces.UIComponentBase we need that the generated components: > > > > > > > > a. Do not call super(rendererType) in the constructor. Instead > > > > > > > > call setRendererType(rendererType) > > > > > > > > b. Do not use FacesBean.TYPE. Don't generate then the method > > > > > > > > getBeanType and don't generate the static TYPE.lockAndRegisterthing. > > > > > > > > c. Do not user PropertyKey. The accessor methods for the > > > > > > > > properties would not call methods from the superclass > > > > > > > > > > > > > > > > We could have then, a specific parameter in the configuration of the > > > > > > > > plugin to toggle this behaviour. I think that, a part from this, > > > > > > > > everything would be generated ok when we write all the xml files for > > > > > > > > the components. This plugin does great work. > > > > > > > > > > > > > > > > Do you think I am missing something or do you have better ideas? > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > > > > > > > Bruno > > > > > > > > > > > > > > > > On 10/26/06, Adam Winer <[EMAIL PROTECTED]> wrote: > > > > > > > > > On 10/26/06, Bruno Aranda <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > I am trying to understand in detaild the maven-faces-plugin > > > > > usage. Is > > > > > > > > > > there any documentation? I am evaluating the amount of work > > > > > needed if > > > > > > > > > > we follow the same way than trinidad to generate tags, config > > > > > files, > > > > > > > > > > etc... > > > > > > > > > > > > > > > > > > > > > > > > > > > There'd need to be support added for generating components and > > > > > > > > > tags that inherit from UIComponentBase and UIComponentELTag > > > > > > > > > instead of UIXComponentBase and UIXComponentELTag. That'd > > > > > > > > > be rather easy to do, if a bit tedious. > > > > > > > > > > > > > > > > > > I'd be very happy to help point interested developers in the right > > > > > > > > > direction. > > > > > > > > > > > > > > > > > > Also the intention is to generate the taglibs 1.2 for myfaces 1.2, > > > > > > > > > > with the deferred-value/method attributes etc. Up to what extent > > > > > this > > > > > > > > > > is possible with the current implementation of the plugin? > > > > > > > > > > > > > > > > > > > > > > > > > > > Support for generating JSP 2.1 - including deferred-value, > > > > > > > > > method-expression, etc. - is already in on the JSF 1.2 branch > > > > > > > > > of Trinidad. > > > > > > > > > > > > > > > > > > -- Adam > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Matthias Wessendorf > > > > > > http://tinyurl.com/fmywh > > > > > > > > > > > > further stuff: > > > > > > blog: http://jroller.com/page/mwessendorf > > > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Matthias Wessendorf > > http://tinyurl.com/fmywh > > > > further stuff: > > blog: http://jroller.com/page/mwessendorf > > mail: mwessendorf-at-gmail-dot-com > > > -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
-- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
