[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: UNIT_TESTS_Java_5.zip
Convert unit tests for both API and IMPL project. I also had to modify around 6
clases from API and IMPL to either infer types differently or remove
parametrization (Service provider namely which is sad because the parametrized
version was nice).
Since there's no unit tests for unit tests, I tried to modify the classes the
least possible, like I only applied enhanced for loop structure in two places
where it was very obvious that the wanted behavior was to loop across all
entries, all other loops remain unchanged.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch,
> DEMO_DateField_Java_5.patch, DEMO_java_5.patch,
> DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, I18N_Java_5.patch,
> IMPL_5_standard.zip, SubKeyMap_Java_5.patch, TAG_Java_5.patch,
> UNIT_TESTS_Java_5.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing
> Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only
> when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever
> possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that
> returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
