[ http://issues.apache.org/jira/browse/ADFFACES-72?page=all ]
Simon Lessard updated ADFFACES-72:
----------------------------------
Attachment: FINAL_Java_5.zip
Changed Collections.EMPTY_* to Collections.empty* since those are typesafe.
This change allowed me to remove tome of the @SuppressWarnings("unchecked")
that are not so desirable.
Also removed parametrization from RowKeySet to fix it to Set<Object>. This
removed many warning as well some @SuppressWarnings and made the code cleaner
imho.
Redid the parametrization of XMLMenuModel, making the XMLMenuModel patch I
posted before for this issue obsolete.
Made inputNumberSpinbox Java 5 compliant.
Also fixed some more little details that showed up in the warning list now that
my warning count is below 100 (47 actually).
The only remaining warnings are:
- Use of deprecated API
- Boolean assignment in an evaluation, used by assert enabledAssertion = true
statements for instance.
- Missing @Override for some methods of autogenerated components. This issue is
linked to the fact that maven-faces-plugin cannot detect methods it's
overriding. Using a static list of method could works, but I would prefer to
avoid that personally.
> Convert Trinidad to Java 5 standards and clean-up code
> ------------------------------------------------------
>
> Key: ADFFACES-72
> URL: http://issues.apache.org/jira/browse/ADFFACES-72
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: API_1_5_standard.zip, API_template.patch,
> DEMO_DateField_Java_5.patch, DEMO_java_5.patch,
> DEMO_SourceCodeServlet_Java_5.patch, Faces_plugin.patch, FINAL_Java_5.zip,
> I18N_Java_5.patch, IMPL_5_standard.zip, SubKeyMap_Java_5.patch,
> TAG_Java_5.patch, UI_Java_5.zip, UNIT_TESTS_Java_5.zip,
> UNIT_UI_Java_5_v2.zip, XRTS_java_5.patch
>
>
> This is a non critical long term improvement that should convert existing
> Trinidad code to Java 5.0 standard:
> - Remove references to deprecated API
> - Remove unused imports
> - Remove unread variables
> - Change StringBuffer to StringBuilder where synchronization is not required
> - Reduce to minimum the use of raw type collections (they should be used only
> when calling an external 1.4 API)
> - Make all collection generic compliant
> - Use the enhanced 'for' construct in favor to classical 'for' whenever
> possible to reduce potential OutOfBoundsException risks
> - Use enums
> - Use concurrent API
> - Add @Override annotation on overridden methods
> - Add @SuppressWarning("unchecked") on method calling external method that
> returns non-generic enabled collections
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
