[
https://issues.apache.org/jira/browse/ADFFACES-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott O'Bryan updated ADFFACES-374:
-----------------------------------
Attachment: 12-ADFFACES-374.patch
This is a patch to fix this issue and is only applied to the 1.2 branch. All
of the base wrappers now use getRequest and setRequest.
Also, Bug 493 in JSF1.2_03 and earlier is handled using a special wrapper class
now applied by the global configurator. This issue will be fixed by the RI as
of JSF1.2_04.
Finally, a special ExternalContextDecorator was also added when running as a
Portlet which allows a Trinidad developer to use the setRequest and getRequest
methods with the Trinidad wrappers. This functionality will be needed until
wrappers are officially supported by JSR-286.
Committers - Please note that the following files have been removed as part of
this patch:
trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/config/upload/PortletUploadedExternalContext
trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/config/upload/ServletUploadedExternalContext
... and the following file was added:
trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/config/upload/ActionUploadRequestWrapper
> In JSF1.2, configurators should use setRequest and setResponse where possible
> -----------------------------------------------------------------------------
>
> Key: ADFFACES-374
> URL: https://issues.apache.org/jira/browse/ADFFACES-374
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Components: Portlet
> Environment: JSF1.2
> Reporter: Scott O'Bryan
> Attachments: 12-ADFFACES-374.patch
>
>
> In JSF1.1, the configurators in trinidad would need to override the
> ExternalContext object in order to provide access to functionality on the
> native Request and Response. These wrappers simply overrode functionality
> impacted by the wrapped object. This was somewhat error prone and left a lot
> of room for issues. As of JSF 1.2 there are setRequest and setResponse
> methods on the ExternalContext which allows you to switch out these objects
> but still rely on the container's implementation. The JSF 1.2 version of
> Trinidad should use this mechanism where possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
