Hey, thank you Adam

Adam Winer (JIRA) wrote:
     [ 
https://issues.apache.org/jira/browse/ADFFACES-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Winer updated ADFFACES-374:
--------------------------------

    Resolution: Fixed
      Assignee: Adam Winer
        Status: Resolved  (was: Patch Available)

Checked in the patch - thanks, Scott.

In JSF1.2, configurators should use setRequest and setResponse where possible
-----------------------------------------------------------------------------

                Key: ADFFACES-374
                URL: https://issues.apache.org/jira/browse/ADFFACES-374
            Project: MyFaces ADF-Faces
         Issue Type: Improvement
         Components: Portlet
        Environment: JSF1.2
           Reporter: Scott O'Bryan
        Assigned To: Adam Winer
        Attachments: 12-ADFFACES-374.patch


In JSF1.1, the configurators in trinidad would need to override the 
ExternalContext object in order to provide access to functionality on the 
native Request and Response.  These wrappers simply overrode functionality 
impacted by the wrapped object.  This was somewhat error prone and left a lot 
of room for issues.  As of JSF 1.2 there are setRequest and setResponse methods 
on the ExternalContext which allows you to switch out these objects but still 
rely on the container's implementation.  The JSF 1.2 version of Trinidad should 
use this mechanism where possible.


Reply via email to