Hi Tom, I've read the tag-length-value draft specification multiple times quickly, and once carefully. Though I'm not expert in volser, the proposed protocol seems very coherent and reasonable.
Though it's a nit, I find some of the long token constants (e.g., "VOLSERTAGUNSUPPORTEDENCODING") hard to read. It might be nice to break up the token namespace with understores (e.g., "VOLSER_TAG_UNSUPPORTED_ENCODING"), if the token length exceeds some minumum (14 characters seems plausible)? This is already done for most token namespaces in the draft. I wondered also if the tag cache coherence ambiguity could be helped through the use of some type of data version or serialization token in relevant calls? Matt ----- "Tom Keiser" <[email protected]> wrote: > Hi All, > > Now that the elections are complete, I'd like to make a second call > for review of draft-tkeiser-afs3-volser-tlv-03. Any feedback would > be > greatly appreciated. > > Cheers, > > -Tom > > > Tom Keiser <[email protected]> wrote: > > The other week I submitted a new draft to the IETF which implements > > the aforementioned changes (as well as a few others). The new > draft > > is available at the following URLs: > > > > http://tools.ietf.org/html/draft-tkeiser-afs3-volser-tlv-03 > > > http://openafs.sinenomine.net/~tkeiser/i-d/draft-tkeiser-afs3-volser-tlv-03.html > > > http://openafs.sinenomine.net/~tkeiser/i-d/draft-tkeiser-afs3-volser-tlv-03.xml > > > http://openafs.sinenomine.net/~tkeiser/i-d/draft-tkeiser-afs3-volser-tlv-02-03.xml.diff > > > > > /afs/sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-03.txt > > > /afs/sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-03.html > > > /afs/sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-03.xml > > > /afs/sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-02-03.xml.diff > > > > > > The complete revision history is as follows: > > > > - split unsigned 64-bit type down into several more descriptive > types > > that allow the TLV data stream to be more self-describing. > > - add a signed 64-bit integer type to allow for relative timestamps > > - now that we have more descriptive types, use them in a number of > places > > - change AFSVOL_TLV_TAG_VOL_TRANS_CALL_VALID into a boolean type > payload > > - make sure rxgen can parse the XDR in the appendix > > - make sure generated C code compiles and links > > - add in-text cites for AFS3-VVL, AFS3-FSCM, DAFS, and OSD. > > - provide motivations for GetCapabilities RPC > > - provide protocol semantic definitions for each newly allocated > capability bit > > - allocate AFSVOL_TLV_FLAG_MORE bit to notify caller when we can't > > send all tags due to AFSVOL_TLV_TAG_MAX length limit > > > > Any comments or feedback are appreciated. > > > > -Tom > > > > _______________________________________________ > AFS3-standardization mailing list > [email protected] > http://michigan-openafs-lists.central.org/mailman/listinfo/afs3-standardization -- Matt Benjamin The Linux Box 206 South Fifth Ave. Suite 150 Ann Arbor, MI 48104 http://linuxbox.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309 _______________________________________________ AFS3-standardization mailing list [email protected] http://lists.openafs.org/mailman/listinfo/afs3-standardization
