On Dec 7, 2010 10:47 AM, "Tom Keiser" <[email protected]> wrote: > > Hi All, > > Now that the elections are complete, I'd like to make a second call > for review of draft-tkeiser-afs3-volser-tlv-03. Any feedback would be > greatly appreciated. >
Question: when I introduced AFSVOL_TLV_TYPE_TIME_ABS and AFSVOL_TLV_TYPE_TIME_ABS_VEC in draft -03, I mapped them to uint64 types; would it be preferable for them to be signed? -Tom > Cheers, > > -Tom > > > Tom Keiser <[email protected]> wrote: > > The other week I submitted a new draft to the IETF which implements > > the aforementioned changes (as well as a few others). The new draft > > is available at the following URLs: > > > > http://tools.ietf.org/html/draft-tkeiser-afs3-volser-tlv-03 > > http://openafs.sinenomine.net/~tkeiser/i-d/draft-tkeiser-afs3-volser-tlv-03.html > > http://openafs.sinenomine.net/~tkeiser/i-d/draft-tkeiser-afs3-volser-tlv-03.xml > > http://openafs.sinenomine.net/~tkeiser/i-d/draft-tkeiser-afs3-volser-tlv-02-03.xml.diff > > > > /afs/ sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-03.txt > > /afs/ sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-03.html > > /afs/ sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-03.xml > > /afs/ sinenomine.net/user/tkeiser/public_html/i-d/draft-tkeiser-afs3-volser-tlv-02-03.xml.diff > > > > > > The complete revision history is as follows: > > > > - split unsigned 64-bit type down into several more descriptive types > > that allow the TLV data stream to be more self-describing. > > - add a signed 64-bit integer type to allow for relative timestamps > > - now that we have more descriptive types, use them in a number of places > > - change AFSVOL_TLV_TAG_VOL_TRANS_CALL_VALID into a boolean type payload > > - make sure rxgen can parse the XDR in the appendix > > - make sure generated C code compiles and links > > - add in-text cites for AFS3-VVL, AFS3-FSCM, DAFS, and OSD. > > - provide motivations for GetCapabilities RPC > > - provide protocol semantic definitions for each newly allocated capability bit > > - allocate AFSVOL_TLV_FLAG_MORE bit to notify caller when we can't > > send all tags due to AFSVOL_TLV_TAG_MAX length limit > > > > Any comments or feedback are appreciated. > > > > -Tom > >
