On 11/23/05, David Zülke <[EMAIL PROTECTED]> wrote: > > I have issues with #10 (disable config checks) just because this has > > history with me... Being as I haven't been involved lately though, > > I'll go with whatever you guys think. What are my issues? Don't we > > still have a race condition with building that cached config file if > > it doesn't exist? I'd rather find a *real* solution to that problem > > rather than a hack to prevent a good number of the stat calls, but > > still have the (albeit slight) possibility of a race.. Again, I'm > > more than out of the loop, so feel free to argue this one. > > Well... see my other mail on this topic (reply to Veikko's mail). There > won't be a race condition, since nothing is generated at all when it's used. > It's a use-with-caution setting.
OK.. so this assumes that you've run your app with the flag off at least once (to get agavi to compile the config caches), and then turn the flag off. Hmm.. It just seems kludgy to me. Now if we had a phing task which would create the config caches (not even sure if that's possible.. I haven't had my coffee yet), I would buy this in a heartbeat. Whaddya think? > > > > Extra point a): as long as you're going to do what was discussed in > > that mail thread, I'm all for it. Make me tell you where my agavi > > installation is (or rather the agavi installation I want to use (I > > might have many!)) in my index.php, but don't bother me otherwise. I > > should only have one place to worry about. > > Okay. Still not sure whether we should > a) require definition of AG_APP_DIR inside config.php and use it in > index.php (require(AG_APP_DIR . '/agavi.php');) or > b) auto-set AG_APP_DIR (this is what's being done at the moment) inside > agavi.php, which means people have to supply a path to their agavi.php > location in index.php > The definition of AG_WEBAPP_DIR will have to remain in config.php for > obvious reasons, though. > I like b) - auto-set AG_APP_DIR inside agavi.php, and make people specify the path to the agavi installationa (agavi.php in this case) they want to use inside of index.php. > > > Extra point b): see response to #10 ;) but: AG_AUTOUPDATE_CONFIGCACHE > > , AG_RECACHE_CONFIGS , whatever.. if this goes in we need a big fat > > wiki page about tweaking installations for "production" environments > > :) (probably a nice idea anyway) > > > > Extra point c): I like simplicity. Having defaults is a nice thing, > > and I agree the performance impact of a couple extra ifdefs should be > > nothing. I say go for that. > > Right. > > > > Hope you guys are all doing well and have a great Thanksgiving (if you > > celebrate that sorta thing ;) ) If you don't, get drunk and eat a > > lot, but don't really *do* anything. Seriously though.. thanks for > > continuing to push and stay active. I hope you'll see more of me from > > now on. > > No. Never really got what all the Thanksgiving buzz is about. Why are you > crazy Americans celebrating it anyway? =) I only know the Turkey is > mandatory. But getting drunk and eating a lot sure sounds good. Maybe I > should move to the U.S. (we also have something that translates to > "Thanksgiving", but it takes place in October, and we don't really celebrate > it, it's not a holiday either). > > Anyways... have a nice Thanksgiving, Bob ;) Thanks.. you too! --Bob > > - David > > > _______________________________________________ > agavi-dev mailing list > [email protected] > http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev > _______________________________________________ agavi-dev mailing list [email protected] http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev
