Can we please postpone this until after 0.10? We need to discuss this a bit before we can agree on an implementation. I certainly don't want the timespan between 0.10 and 0.11 to be as large as the one between 0.9 and 0.10. I got some things on my ToDo for 0.11 (and will add tickets for them), and we could add such a functionality.
- David > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > Behalf Of Steven Weiß > Sent: Friday, November 25, 2005 6:26 PM > To: Agavi Development > Subject: Re: [agavi-dev] declarative exception handling in agavi? > > hi, > i just implemented the idea of ahmed (see mail below). attached are the > modified files + a new config file "exceptions.ini" where you can setup > actions for > the exception types (the most derived type will be taken into account ;-) > ). > > while developing, i saw that the dispatch()-functions of the different > controllers have a different interface (some with arguments, some > without). first i wanted > to change the controller's dispatch()-method to be a final function > calling dispatchImpl() which would then be abstract (template method > pattern). but because > of these different interfaces and the different docs i decided to add a > protected function handleException() to controller which does the work > of forwarding > to the appropriate exception's action. therefore in every derived > controller i had to write > try { > ... > } catch (Exception $e) { > $this->handleException($e); > } > > which solution do you prefer? do you like ahmed's idea at all? > > mfg steven > > > Ahmed Saad wrote: > > >Hi all, > > > >What about adding declarative exception handling in Agavi? It simpley > >means that the controller would call a specified action when some > >unhandled exception (of some type) is thrown. You would add something > >like this to settings.ini (or somewhere else?) > > > >[Exceptions] > >PropelException = Default,InternalError > >CustomException = CustomModule,CustomAction > > > >Here the controller would call InternalErrorAction in the Default > >module when it catches an unhandled PropleException and so on. I'm > >gonna play a little with that today. > > > >Comments are welcome. > > > >-ahmed > > > > > >------------------------------------------------------------------------ > > > >_______________________________________________ > >agavi-dev mailing list > >[email protected] > >http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev > > > > > > > -- > mfg Steven Weiß > > > ------------------------------------------------- > Steven Weiß > code-factory - Programming, Webdesign, PC-Service > > Anton-Uhrenbacherstr. 10 > 77977 Rust > > Telefon: (07822) 440668 > Handy: (0178) 3832347 > [EMAIL PROTECTED] > http://www.code-factory.de > ------------------------------------------------- > > _______________________________________________ agavi-dev mailing list [email protected] http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev
