Adding /tests and /user in there as well ...
On Tue, Nov 10, 2015 at 11:12 AM, Davide Libenzi <[email protected]> wrote: > Yep, it does. > > > On Tue, Nov 10, 2015 at 11:10 AM, Davide Libenzi <[email protected]> > wrote: > >> It was compiling fine for me. >> Yes, I had to fix manually what you mention, but again, it is building >> fine, my branch. >> Let me triple check ... >> >> >> On Tue, Nov 10, 2015 at 11:07 AM, Barret Rhoden <[email protected]> >> wrote: >> >>> On 2015-11-10 at 09:02 "'Davide Libenzi' via Akaros" >>> <[email protected]> wrote: >>> > Same branch. Try how it looks now ... >>> >>> Thanks. This merges, but there are a couple issues. >>> >>> A minor one is that the headers in user/ and tests/ weren't included. >>> >>> The big one is that this changes the kernel headers and actually >>> breaks the compilation. The issue is stuff like this: >>> >>> kern/arch/x86/ros/syscall64.h:#error "Do not include include >>> ros/arch/syscall64.h directly" >>> >>> this is what pops up: >>> >>> #ifndef ROS_INC_ARCH_SYSCALL_H >>> #error "Do not include include ros/arch/syscall64.h directly" >>> #endif >>> >>> since we no longer define ROS_INC_ARCH_SYSCALL_H >>> >>> There's about 10 of these throughout the kernel and user space >>> headers. (git grep "Do not include"). >>> >>> A couple options: >>> 1) Keep the #error, but go into the header that should have been >>> included and #define something like INCLUDED_INC_SYSCALL >>> 2) Just remove all of those checks. They aren't really a big deal >>> anyways. >>> >>> Either option works for me, or whatever else people suggest. The >>> cleanest way to do it is to make one commit that makes the change >>> (option 1, 2, etc), then do the big perl script change in another >>> commit. >>> >>> Barret >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Akaros" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
