Does everything build cleanly for you Davide if you run: make xcc-upgrade-from-scratch?
it sounds like this is where it is breaking for barret. On Tue, Nov 10, 2015 at 3:22 PM, 'Davide Libenzi' via Akaros <[email protected]> wrote: > Did the commit apply correctly? > Yes, the #error is still there, but the ones including it, are correctly > defining what that file wants. > > > On Tue, Nov 10, 2015 at 12:18 PM, Barret Rhoden <[email protected]> > wrote: >> >> On 2015-11-10 at 11:19 "'Davide Libenzi' via Akaros" >> <[email protected]> wrote: >> > Done. >> > That branch builds for me, let me know otherwise. >> > Yes, even in parlib, I had to manually fix one of those issues that >> > you mentioned. >> > There were a few on kern/. >> >> Maybe I'm missing it, but it still doesn't build for me. I'm looking >> at commit: >> >> 21a42fcec7a1 ("Migrated Akaros code to use pragma once include file >> marker") >> >> It has the user and tests changes, but it still has the #error stuff. >> e.g.: >> >> diff --git a/kern/arch/x86/ros/syscall64.h b/kern/arch/x86/ros/syscall64.h >> index 4ec8e85b8bf9..7b63ca745b7e 100644 >> --- a/kern/arch/x86/ros/syscall64.h >> +++ b/kern/arch/x86/ros/syscall64.h >> @@ -1,5 +1,4 @@ >> -#ifndef ROS_INC_ARCH_SYSCALL64_H >> -#define ROS_INC_ARCH_SYSCALL64_H >> +#pragma once >> >> #ifndef ROS_INC_ARCH_SYSCALL_H >> #error "Do not include include ros/arch/syscall64.h directly" >> >> >> Can you remove or rename the #define for those cases in a single >> commit, then run the perl script for another commit? >> >> Thanks, >> >> Barret >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Akaros" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- ~Kevin -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
