To be clear to others following this, the rules from here forward are to use #pragma once in new header files, instead of the usual:
#ifndef THING #define THING .... #endif On Wed, Nov 11, 2015 at 11:38 AM, Barret Rhoden <[email protected]> wrote: > Thanks, merged to staging at a759dfde3f64..1ed63f9f8e25 (from, to] > > You can see the entire diff with 'git diff' or at > https://github.com/brho/akaros/compare/a759dfde3f64...1ed63f9f8e25 > > > > On 2015-11-10 at 14:53 "'Davide Libenzi' via Akaros" > <[email protected]> wrote: >> OK, now even xcc saga is building. It was just one fix needed. >> >> >> On Tue, Nov 10, 2015 at 2:29 PM, Davide Libenzi <[email protected]> >> wrote: >> >> > Let me check that (and wait a little, since xcc is longish) ... >> > >> > >> > On Tue, Nov 10, 2015 at 2:28 PM, Davide Libenzi >> > <[email protected]> wrote: >> > >> >> Oh, wait, I did not run the xcc saga ... >> >> >> >> >> >> On Tue, Nov 10, 2015 at 1:53 PM, Barret Rhoden >> >> <[email protected]> wrote: >> >> >> >>> On 2015-11-10 at 12:22 "'Davide Libenzi' via Akaros" >> >>> <[email protected]> wrote: >> >>> > Did the commit apply correctly? >> >>> > Yes, the #error is still there, but the ones including it, are >> >>> > correctly defining what that file wants. >> >>> >> >>> looks like it still doesn't work for me. for example: >> >>> >> >>> $ cd tools/compilers/gcc-glibc/ >> >>> $ make x86_64 >> >>> >> >>> (eventual errors like this): >> >>> >> >>> >> >>> /home/brho/akaros/ros-gcc-glibc/install-x86_64-ros-gcc/x86_64-ucb-akaros/sysroot/usr/include/ros/arch/syscall64.h:4:2: >> >>> error: #error "Do not include include ros/arch/syscall64.h >> >>> directly" #error "Do not include include ros/arch/syscall64.h >> >>> directly" >> >>> >> >>> looking at kern/arch/x86/ros/syscall64.h: >> >>> >> >>> #ifndef ROS_INC_ARCH_SYSCALL_H >> >>> #error "Do not include include ros/arch/syscall64.h directly" >> >>> #endif >> >>> >> >>> >> >>> then looking for a #define of INC_ARCH_SYSCALL_H: >> >>> >> >>> $ git grep ROS_INC_ARCH_SYSCALL_H >> >>> kern/arch/x86/ros/syscall64.h:#ifndef ROS_INC_ARCH_SYSCALL_H >> >>> >> >>> that appears in just one location, and is never #defined. maybe >> >>> just that one is busted? >> >>> >> >>> barret >> >>> >> >>> >> >>> -- >> >>> You received this message because you are subscribed to the Google >> >>> Groups "Akaros" group. >> >>> To unsubscribe from this group and stop receiving emails from it, >> >>> send an email to [email protected]. >> >>> To post to this group, send email to [email protected]. >> >>> For more options, visit https://groups.google.com/d/optout. >> >>> >> >> >> >> >> > >> > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- ~Kevin On Wed, Nov 11, 2015 at 8:38 AM, Barret Rhoden <[email protected]> wrote: > Thanks, merged to staging at a759dfde3f64..1ed63f9f8e25 (from, to] > > You can see the entire diff with 'git diff' or at > https://github.com/brho/akaros/compare/a759dfde3f64...1ed63f9f8e25 > > > > On 2015-11-10 at 14:53 "'Davide Libenzi' via Akaros" > <[email protected]> wrote: >> OK, now even xcc saga is building. It was just one fix needed. >> >> >> On Tue, Nov 10, 2015 at 2:29 PM, Davide Libenzi <[email protected]> >> wrote: >> >> > Let me check that (and wait a little, since xcc is longish) ... >> > >> > >> > On Tue, Nov 10, 2015 at 2:28 PM, Davide Libenzi >> > <[email protected]> wrote: >> > >> >> Oh, wait, I did not run the xcc saga ... >> >> >> >> >> >> On Tue, Nov 10, 2015 at 1:53 PM, Barret Rhoden >> >> <[email protected]> wrote: >> >> >> >>> On 2015-11-10 at 12:22 "'Davide Libenzi' via Akaros" >> >>> <[email protected]> wrote: >> >>> > Did the commit apply correctly? >> >>> > Yes, the #error is still there, but the ones including it, are >> >>> > correctly defining what that file wants. >> >>> >> >>> looks like it still doesn't work for me. for example: >> >>> >> >>> $ cd tools/compilers/gcc-glibc/ >> >>> $ make x86_64 >> >>> >> >>> (eventual errors like this): >> >>> >> >>> >> >>> /home/brho/akaros/ros-gcc-glibc/install-x86_64-ros-gcc/x86_64-ucb-akaros/sysroot/usr/include/ros/arch/syscall64.h:4:2: >> >>> error: #error "Do not include include ros/arch/syscall64.h >> >>> directly" #error "Do not include include ros/arch/syscall64.h >> >>> directly" >> >>> >> >>> looking at kern/arch/x86/ros/syscall64.h: >> >>> >> >>> #ifndef ROS_INC_ARCH_SYSCALL_H >> >>> #error "Do not include include ros/arch/syscall64.h directly" >> >>> #endif >> >>> >> >>> >> >>> then looking for a #define of INC_ARCH_SYSCALL_H: >> >>> >> >>> $ git grep ROS_INC_ARCH_SYSCALL_H >> >>> kern/arch/x86/ros/syscall64.h:#ifndef ROS_INC_ARCH_SYSCALL_H >> >>> >> >>> that appears in just one location, and is never #defined. maybe >> >>> just that one is busted? >> >>> >> >>> barret >> >>> >> >>> >> >>> -- >> >>> You received this message because you are subscribed to the Google >> >>> Groups "Akaros" group. >> >>> To unsubscribe from this group and stop receiving emails from it, >> >>> send an email to [email protected]. >> >>> To post to this group, send email to [email protected]. >> >>> For more options, visit https://groups.google.com/d/optout. >> >>> >> >> >> >> >> > >> > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- ~Kevin -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
