On 2015-11-30 at 11:07 "'Davide Libenzi' via Akaros" <[email protected]> wrote: > We can't panic if a userspace program provided us badly formatted > data ☺
Yes, we absolutely cannot. I wasn't clear on what you were erroring or panicking about. =) > In general, we follow that rule too. Most macros are uppercase. Some > > aren't where the macro is a wrapper of some sort. For example, some > > functions like printx and printk are macros, but the intended > > interface is to be a function; there's no "thread carefully" > > warning needed. > > > > I don't know if assert() requires the level of warning associated > > with macros, esp considering that assert() already exists and all > > of our existing code treats asserts and warns in lowercase. It's > > not like someone is going to get confused by the lack of uppercase. > > > > So, since it is in that file (assert.h), it should be lowercase as > well? Yes please. It'll also keep it in the same style as the other error() calls (like waserror() and error()). -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
