Fixed. The "writting" one seems to be in an old commit message, which is not in this branch, AFAICS.
On Tue, Dec 15, 2015 at 10:53 AM, Barret Rhoden <[email protected]> wrote: > Hi - > > Not sure, but your checkpatch stuff still seems to be missing things. > Do the commit hooks run on rebase? Here's ones that don't look like > false positives: > > ../patches/0013-Reverted-prof-kpctl-interface-to-split-start-and-tim.patch > -------------------------------------------------------------------------- > WARNING: 'ouput' may be misspelled - perhaps 'output'? > #149: FILE: Documentation/profiling.txt:132: > +providing the event coordinates (of which, the ouput emitted by the > commands > > ../patches/0017-Added-perfmon-interrupt-handling-to-allow-overflow-b.patch > -------------------------------------------------------------------------- > ERROR: trailing whitespace > #31: FILE: kern/arch/x86/perfmon.c:6: > +#include <sys/types.h> $ > > ERROR: trailing whitespace > #32: FILE: kern/arch/x86/perfmon.c:7: > +#include <arch/ros/msr-index.h> $ > > ERROR: trailing whitespace > #546: FILE: kern/arch/x86/perfmon.h:8: > +#include <sys/types.h> $ > > ../patches/0019-Added-new-perf-utility-to-access-CPU-counters-from-u.patch > -------------------------------------------------------------------------- > ERROR: spaces required around that ':' (ctx:VxW) > #226: FILE: tools/profile/perf/akaros.c:116: > + size_t nb = (max_cores >= CHAR_BIT) ? CHAR_BIT: max_cores; > > > ../patches/0020-Enable-the-PFM-sampling-to-pass-an-64bit-info-value.patch > ------------------------------------------------------------------------- > ERROR: trailing whitespace > #28: FILE: kern/arch/x86/perfmon.c:8: > +#include <arch/ros/membar.h> $ > > ../patches/0021-Implement-flush-capability-for-the-profiler-tracing-.patch > -------------------------------------------------------------------------- > WARNING: 'writting' may be misspelled - perhaps 'writing'? > #7: > per CPU buffers to be writting into the main queue, so that data is > > ../patches/0023-Move-Linux-perf-format-conversion-into-perf-tool-dro.patch > -------------------------------------------------------------------------- > ERROR: "foo* bar" should be "foo *bar" > #1461: FILE: tools/profile/perf/xlib.c:218: > +const char* vb_decode_uint64(const char *data, uint64_t *pval) > > ERROR: "foo* bar" should be "foo *bar" > #1551: FILE: tools/profile/perf/xlib.h:61: > +const char* vb_decode_uint64(const char *data, uint64_t *pval); > > Barret > > > On 2015-12-14 at 14:27 "'Davide Libenzi' via Akaros" > <[email protected]> wrote: > > Done. > > > > > > On Mon, Dec 14, 2015 at 2:22 PM, Davide Libenzi <[email protected]> > > wrote: > > > > > Adding the "pa" thing now. Hold one ... > > > > > > > > > On Mon, Dec 14, 2015 at 2:20 PM, Davide Libenzi > > > <[email protected]> wrote: > > > > > >> Yes, it's a Linux perf record injected. > > >> Plus, we would need something, if we plan to implement uname. > > >> > > >> > > >> On Mon, Dec 14, 2015 at 2:19 PM, Barret Rhoden > > >> <[email protected]> wrote: > > >> > > >>> On 2015-12-14 at 14:18 "'Davide Libenzi' via Akaros" > > >>> <[email protected]> wrote: > > >>> > Currently the knowledge of the Linux perf file format is kept > > >>> > at a minimum. Injecting that information at Linux side would > > >>> > require heavier changes to the Linux perf tool, which I > > >>> > intentionally kept at a minimum, to minimize conflicts in > > >>> > applying to new versions. Similarly, if I have to crack open > > >>> > the perf file at Linux side, we will have to have another tools > > >>> > on the Linux side. > > >>> > > >>> Makes sense. So it sounds like there is a perf record or > > >>> something with the kernel binary location? > > >>> > > >>> -- > > >>> You received this message because you are subscribed to the Google > > >>> Groups "Akaros" group. > > >>> To unsubscribe from this group and stop receiving emails from it, > > >>> send an email to [email protected]. > > >>> To post to this group, send email to [email protected]. > > >>> For more options, visit https://groups.google.com/d/optout. > > >>> > > >> > > >> > > > > > > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
