On Thu, Jun 2, 2016 at 6:24 PM, barret rhoden <[email protected]> wrote:
> Hi -
>
> On 2016-06-02 at 17:30 Dan Cross wrote:
> > Add an Akaros-only sysdeps/akaros/bits/{stdlib,string}-akaros.h
> > with prototypes for reallocarray and strlcpy and strlcat respectively.
> > Modify sysdeps/stdlib.h and sysdeps/string.h to include those headers,
> > respectively. Modify Makefile and Versions to export these functions.
>
> Do we need some sort of #defines to advertise these functions, such as
> HAVE_STRLCAT, so that other projects don't try to implement their own
> version?
>
No; these are usually detected by e.g. autotools. For example, the BSD
projects don't define such symbols.
Also, please mark the commit as (XCC) in the subject and put a note
> about rebuilding glibc. For something like this, I usually just say:
>
> Rebuild glibc.
Just a moment.
> diff --git
> a/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/stdlib.h
> b/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/stdlib.h
> > index d35ffac..1eb54ad 100644
> > --- a/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/stdlib.h
> > +++ b/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/stdlib.h
> > @@ -33,6 +33,10 @@
> >
> > __BEGIN_DECLS
> >
> > +#ifdef __ros__
> > +#include <bits/stdlib-akaros.h>
> > +#endif
> > +
>
> We shouldn't need the ifdef __ros__ around it, since the header is in
> our sysdeps and should only be built for our system.
>
>
> > diff --git
> a/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/string.h
> b/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/string.h
> > index b127e8d..1457cb7 100644
> > --- a/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/string.h
> > +++ b/tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/string.h
> > @@ -31,6 +31,10 @@ __BEGIN_DECLS
> > #define __need_NULL
> > #include <stddef.h>
> >
> > +#ifdef __ros__
> > +#include <bits/string-akaros.h>
> > +#endif
>
> Same here.
>
>
> Thanks,
>
> Barret
>
> --
> You received this message because you are subscribed to the Google Groups
> "Akaros" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
