Hi -

On 2016-06-07 at 12:48 "Ronald G. Minnich" <[email protected]> wrote:
[...]
> +
> +     /* Set up a 1:1 page mapping from physical to virtual
> +      * addresses derived from the (host virtual)
> +      * `kerneladdress`. Be aware that the values stored in the


"from guest virtual to guest physical", right?  (comment is backwards).

If so, I can touch that up on my end if you'd like. 

> +      * table are physical addresses.  This is subtle and mistakes
> +      * are easily disguised due to the identity mapping, so take
> +      * care when manipulating these mappings. */
> +     p1 = &p512[NPTENTRIES];
> +     p2m = &p512[2*NPTENTRIES];

Need spaces around the * operator (I can do this).  Or we can just find
the addr for p1 and p2m by e.g. p1 = (void*)p512 + PGSIZE or something.

Barret

-- 
You received this message because you are subscribed to the Google Groups 
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to