Hi -
Did you clang-format this or something? Checkpatch had a bunch of
complaints:
Barret
ERROR: spaces required around that '=' (ctx:VxV)
#84: FILE: kern/drivers/dev/bridge.c:56:
+static struct dirtab bridgedirtab[]={
^
ERROR: spaces required around that '=' (ctx:VxV)
#95: FILE: kern/drivers/dev/bridge.c:63:
+static struct dirtab portdirtab[]={
^
WARNING: Block comments use * on subsequent lines
#118: FILE: kern/drivers/dev/bridge.c:82:
+/* TODO
+ static Logflag logflags[] =
WARNING: please, no space before tabs
#130: FILE: kern/drivers/dev/bridge.c:94:
+#define TYPE(x) ^I(((uint32_t)(x).path) & 0xff)$
WARNING: please, no space before tabs
#131: FILE: kern/drivers/dev/bridge.c:95:
+#define PORT(x) ^I((((uint32_t)(x).path) >> 8)&(Maxport-1))$
ERROR: trailing whitespace
#276: FILE: kern/drivers/dev/bridge.c:212:
+^I$
ERROR: spaces required around that '=' (ctx:VxV)
#279: FILE: kern/drivers/dev/bridge.c:214:
+ for(i=0; i<COUNT_OF(bridgedirtab); i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#279: FILE: kern/drivers/dev/bridge.c:214:
+ for(i=0; i<COUNT_OF(bridgedirtab); i++) {
^
ERROR: space required before the open parenthesis '('
#279: FILE: kern/drivers/dev/bridge.c:214:
+ for(i=0; i<COUNT_OF(bridgedirtab); i++) {
ERROR: spaces required around that '=' (ctx:VxV)
#284: FILE: kern/drivers/dev/bridge.c:218:
+ for(i=0; i<COUNT_OF(portdirtab); i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#284: FILE: kern/drivers/dev/bridge.c:218:
+ for(i=0; i<COUNT_OF(portdirtab); i++) {
^
ERROR: space required before the open parenthesis '('
#284: FILE: kern/drivers/dev/bridge.c:218:
+ for(i=0; i<COUNT_OF(portdirtab); i++) {
ERROR: "foo* bar" should be "foo *bar"
#322: FILE: kern/drivers/dev/bridge.c:248:
+bridgestat(struct chan* c, uint8_t* db, int n)
ERROR: "foo* bar" should be "foo *bar"
#322: FILE: kern/drivers/dev/bridge.c:248:
+bridgestat(struct chan* c, uint8_t* db, int n)
ERROR: "foo* bar" should be "foo *bar"
#331: FILE: kern/drivers/dev/bridge.c:254:
+bridgeopen(struct chan* c, int omode)
ERROR: trailing whitespace
#350: FILE: kern/drivers/dev/bridge.c:267:
+^I^I/* TODO: we might want log someday? $
WARNING: Block comments use * on subsequent lines
#351: FILE: kern/drivers/dev/bridge.c:268:
+ /* TODO: we might want log someday?
+ case Qlog:
ERROR: "foo* bar" should be "foo *bar"
#363: FILE: kern/drivers/dev/bridge.c:283:
+bridgeclose(struct chan* c)
WARNING: please, no space before tabs
#379: FILE: kern/drivers/dev/bridge.c:293:
+^I^I * ^Icase Qlog:$
WARNING: Block comments use * on subsequent lines
#411: FILE: kern/drivers/dev/bridge.c:318:
+ /* TODO
+ case Qlog:
WARNING: Block comments use * on subsequent lines
#569: FILE: kern/drivers/dev/bridge.c:434:
+ /* TODO
+ cb = parsecmd(a, n);
WARNING: line over 80 characters
#581: FILE: kern/drivers/dev/bridge.c:445:
+bridgegen(struct chan *c, char *_, struct dirtab*__, int ___, int s, struct
dir *dp)
ERROR: "foo*bar" should be "foo *bar"
#581: FILE: kern/drivers/dev/bridge.c:445:
+bridgegen(struct chan *c, char *_, struct dirtab*__, int ___, int s, struct
dir *dp)
ERROR: space required before the open parenthesis '('
#615: FILE: kern/drivers/dev/bridge.c:479:
+ if(dt == NULL)
ERROR: spaces required around that '<' (ctx:VxV)
#630: FILE: kern/drivers/dev/bridge.c:491:
+ if(s<COUNT_OF(bridgedirtab)) {
^
ERROR: space required before the open parenthesis '('
#630: FILE: kern/drivers/dev/bridge.c:491:
+ if(s<COUNT_OF(bridgedirtab)) {
ERROR: spaces required around that '>=' (ctx:VxV)
#647: FILE: kern/drivers/dev/bridge.c:504:
+ if(s>=COUNT_OF(portdirtab))
^
ERROR: space required before the open parenthesis '('
#647: FILE: kern/drivers/dev/bridge.c:504:
+ if(s>=COUNT_OF(portdirtab))
ERROR: space required before the open parenthesis '('
#711: FILE: kern/drivers/dev/bridge.c:574:
+ if(port != NULL && port->type == type &&
ERROR: space required before the open parenthesis '('
#717: FILE: kern/drivers/dev/bridge.c:579:
+ if(b->port[i] == NULL)
ERROR: space required before the open parenthesis '('
#839: FILE: kern/drivers/dev/bridge.c:683:
+ if(port != NULL && port->type == type &&
WARNING: Block comments use * on subsequent lines
#860: FILE: kern/drivers/dev/bridge.c:698:
+ /* TODO
+ if(port->readp)
ERROR: space required before the open parenthesis '('
#987: FILE: kern/drivers/dev/bridge.c:832:
+ if(buf == NULL)
ERROR: space required before the open parenthesis '('
#1029: FILE: kern/drivers/dev/bridge.c:867:
+ if(i == port->id || b->port[i] == NULL)
ERROR: space required before the open parenthesis '('
#1038: FILE: kern/drivers/dev/bridge.c:879:
+ if(oport != NULL) {
ERROR: space required before the open parenthesis '('
#1072: FILE: kern/drivers/dev/bridge.c:922:
+ if(n < sizeof(struct Tcphdr))
ERROR: space required before the open parenthesis '('
#1096: FILE: kern/drivers/dev/bridge.c:957:
+ if((optr-(uint8_t*)tcphdr) & 1) {
ERROR: space required before the open parenthesis '('
#1140: FILE: kern/drivers/dev/bridge.c:1004:
+ if(bp == NULL)
ERROR: space required before the open parenthesis '('
#1158: FILE: kern/drivers/dev/bridge.c:1041:
+ if(ce == NULL) {
ERROR: space required before the open parenthesis '('
#1247: FILE: kern/drivers/dev/bridge.c:1122:
+ while(xp != NULL && offset && offset >= BLEN(xp)) {
total: 32 errors, 9 warnings, 1351 lines checked
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
../patches/0005-bridge-c-converted-for-Akaros-.patch has style problems, please
review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
