https://github.com/brho/akaros/compare/master...hugelgupf:gdbserver-support?expand=1
Is there any way you could leave comments not in the email? Once we get to this size, it's really hard to sort through making sure that all the comments were addressed. Maybe on the GitHub PR (which I had only opened for my packet) or on the review site we've been using? Chris The following changes since commit 86109dc44d5a17f003b23c0ffc8dc92c9514e631: Fix shifting bug in radix_insert() (2016-08-19 15:57:18 -0400) are available in the git repository at: [email protected]:hugelgupf/akaros.git gdbserver-support for you to fetch changes up to b10b5c233fc63b93011e32acbc4c4bdcdf49ac70: parlib/debug: adding initialization message. (2016-08-23 14:30:10 -0700) ---------------------------------------------------------------- Christopher Koch (7): Moved IDs and added list of threads in uthreads. Defines protocol between gdbserver and a 2LS. parlib: add helper to apply fn to all uthreads. Full end-to-end single-threaded debugging working. parlib/debug: Added ability to store memory and single-step. parlib/debug: add client attach function. parlib/debug: adding initialization message. kern/arch/x86/trap.c | 21 +- tests/block_test.c | 17 +- tests/futex_timeout.c | 9 +- tests/misc-compat.h | 2 +- tests/pthread_barrier_test.c | 13 +- user/parlib/debug.c | 783 ++++++++++++++++++++++++++++++++- user/parlib/include/parlib/debug.h | 228 ++++++++++ user/parlib/include/parlib/uthread.h | 8 + user/parlib/include/parlib/x86/debug.h | 35 ++ user/parlib/include/parlib/x86/trap.h | 17 + user/parlib/thread0_sched.c | 56 ++- user/parlib/uthread.c | 86 +++- user/parlib/vcore.c | 2 + user/parlib/x86/debug.c | 125 ++++++ user/pthread/pthread.c | 15 +- user/pthread/pthread.h | 1 - 16 files changed, 1351 insertions(+), 67 deletions(-) create mode 100644 user/parlib/include/parlib/debug.h create mode 100644 user/parlib/include/parlib/x86/debug.h create mode 100644 user/parlib/x86/debug.c -- Christopher Koch | Software Engineer | [email protected] | 650-214-3546 -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
