Alright, I'm going to fix it manually, but while Ron advised me against the argument, I'm going to say a few things here anyway.
The style guide Akaros has chosen to follow is slightly different from many of the common ones (kernel, llvm, ...) and setting up tools to automate the formatting doesn't quite do it right. It seems I can either choose to (a) format manually, (b) use one out of a number of broken/unconfigurable tools, (c) spend hours or days fixing the broken tools or adding configuration options. It seems that all three of these are a huge waste of time. (And a huge source of frustration.) (Re (c) -- both vim and clang-fmt don't support some of the things Akaros wants out of the box.) It should be made easy for people to work on Akaros. That means one of: - choosing a style guide that is commonly supported in multiple text editors, - making clang-fmt the ground truth, or - spending time fixing clang-fmt to be the current Akaros style guide. You should especially take this into consideration given the developer velocity points that have been brought up over the last few months. Chris On Thu, Sep 1, 2016 at 10:42 AM Barret Rhoden <[email protected]> wrote: > On 2016-09-01 at 16:49 "'Christopher Koch' via Akaros" > <[email protected]> wrote: > > The debug files are clang-fmted. I would rather not change it. (I > > clang-fmted files where I touched a major number of lines, I left other > > files alone so it wouldn't mess up the commit) > > clang-format, like checkpatch and spatch, is just a tool and isn't > always right. i only use it when dealing with code that is so broken > that the few mistakes it makes is worth it for the automation. that's > basically just plan 9 code (not linux code) and ancient akaros code. > > since we're talking about formatting, don't forget to run checkpatch. > here's a bug from the patch in question. if the checkpatch nits aren't > bad, i usually just fix them on my end and don't mention it. > > e.g. > > WARNING: Missing a blank line after declarations > #238: FILE: user/parlib/debug.c:229: > + size_t msg_size = hdr->size - sizeof(struct d9_header); > + if (msg_size > 0 && read_all(debug_fd, hdr + 1, msg_size)) > > barret > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Christopher Koch | Software Engineer | [email protected] | 650-214-3546 -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
