On Thu, Oct 13, 2016 at 3:47 PM barret rhoden <[email protected]> wrote:
> Hi -
>
> Couple minor things:
>
> > @@ -99,8 +85,8 @@ static int32_t capstat(struct chan *c, uint8_t *db,
> int32_t n)
> > static struct chan *capopen(struct chan *c, int omode)
> > {
> > if (c->qid.type & QTDIR) {
> > - if (omode != OREAD)
> > - error(Ebadarg);
> > + if (omode != O_RDONLY)
> > + error(EISDIR, "Is a directory");
> > c->mode = omode;
>
> I think we might want/need to run omode through openmode(). The other
> drivers do something like:
>
I'd like to not mess with this but just now. But later, yes. This device is
pretty subtle so I don't like to make such changes right off.
I changed user back to user[64].
ron
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
