On 2016-10-14 at 20:27 ron minnich wrote:
> > I think we might want/need to run omode through openmode(). The other
> > drivers do something like:
> I'd like to not mess with this but just now. But later, yes. This device is
> pretty subtle so I don't like to make such changes right off.
Sounds fine. The openmode() change was something I noticed in a bunch
of devices. I think some had it and some didn't, and I think at some
point it became the right thing for all devices, at least in my head.
these call it directly:
these call it via devopen():
Fun tidbit, these C files aren't actual devices (which is fine):
There aren't any devices that don't call it, though my searching might
have missed things. For instance, #proc is a total mess and does all
sorts of things with omode checks.
Anyway, we can leave #capability as is. Basically the omode must be
O_READ there, based on the if check, so it's OK.
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to firstname.lastname@example.org.
For more options, visit https://groups.google.com/d/optout.