Jeremy Huntwork wrote:
[EMAIL PROTECTED] wrote:
- # Skipping scripts is done now so they are not included in the
Makefile.
- case $this_script in
- *stripping*) continue ;;
- *grub*) continue ;;
- esac
- #
+ # Test if the stripping phase must be skipped
+ if [ "$STRIP" = "0" ] && [[ `_IS_ ${this_script} stripping` ]] ;
then
+ continue
+ fi
+
I know we discussed this before once, but I would appreciate a reminder.
Why do we use a custom function (and that much more overhead) for string
comparison when the case built-ins would do the job just as well?
The overhead was minimal with the function call.. BUT I have started
to mix the styles when the case statement made the code clearer. For me
it was just a matter of personal taste, this branch was just my take on
the TODO list.
--
JH
--
http://linuxfromscratch.org/mailman/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
