To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=40170
------- Additional comments from [EMAIL PROTECTED] Mon Jan 17 05:07:46 -0800 2005 ------- ULONG is not bad "per se", it is its usage in OOo which makes it "evil" ;) Generally speaking, "ULONG" is an abbreviation for "unsigned long". It is perfectly OK to use "unsigned long" in code that is expected to compile on 32bit, as well as 64bit platform, as long as: - it is used consistently all around the program, - and it is not a part of the program responsible for input/output (in which case it should be platform-independent, using network byte order and fixed size types, like sal_uInt32, sal_uInt64, etc.) In this particular case, we violate the 1st requirement. See the declaration of dbaui::OQueryController::getColWidth( sal_uInt16 ) const (dbaccess/source/ui/inc/querycontroller.hxx). It must be sal_uInt32 getColWidth(sal_uInt16 _nPos) const because it returns a field of a vector m_vColumnWidth declared as ::std::vector<sal_uInt32>. The definition of sal_Bool OQueryDesignView::getColWidth( const ::rtl::OUString& rAliasName, const ::rtl::OUString& rFieldName, ULONG& nWidth ) (dbaccess/source/ui/querdesign/QueryDesignView.cxx) then simply fails on nWidth = (*aIter)->GetColWidth(); when it is declared with ULONG& nWidth. However, it is OK with sal_uInt32& nWidth. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
