To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=63183
User gh changed the following:
What |Old value |New value
================================================================================
Assigned to|gh |cmc
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Apr 12 03:22:08 -0700
2006 -------
after reading the patch It just came to my mind that actually only the places
where the data is written to and read from the streams in svcommstream.cxx have
to get changed.
So only casting the USHORT and ULONG where they are actually written/read in
this one cxx file would be enough if I dont oversee anything
By the way I could also have a look at the patches to /tools/source/communi and
svtools/source/plugapp
but apart fomt that it looks good but I have some remarks:
automation/source/inc/icommstream.hxx
why have the read/write/seek use sal_Size and not sal_uInt32/comm_ULONG
Espechially the comm_ULONG ocurances must stay in place since there should only
be used types from commtypes.hxx as mentioned in the comment at the start of
icommstream.hxx
why have the read/write/seek use sal_Size and not sal_uInt32/comm_ULONG
automation/source/inc/svcommstream.hxx
automation/source/server/XMLParser.cxx
- ULONG nTimestamp = (ULONG)aString1.GetToken( 1, ':'
).ToInt64();
- ULONG nPointer = (ULONG)aString1.GetToken( 2, ':'
).ToInt64();
+ ULONG nTimestamp = (sal_uInt32)aString1.GetToken( 1,
':' ).ToInt64();
+ ULONG nPointer = (sal_uInt32)aString1.GetToken( 2, ':'
).ToInt64();
please eather also change the type of the variabe or nothing at all in these
lines
automation/source/server/recorder.cxx
- StatementList::pRet->GenReturn( RET_MacroRecorder,
SmartId(), (USHORT)(M_SetPage|M_RET_NUM_CONTROL),
pWin->GetSmartUniqueOrHelpId().GetNum() );
+ StatementList::pRet->GenReturn( RET_MacroRecorder,
SmartId(), (USHORT)(M_SetPage|M_RET_NUM_CONTROL),
(sal_uInt32)(pWin->GetSmartUniqueOrHelpId().GetNum()) );
I would prefer changing the class UniqueId in vcl not to use ULONG but
sal_uInt32 instead of casting it everywhere. But reading on I see ypu would also
have to do it for helpids (Get/Set/Helpid on Wondow ToolBox ...) SO maybe
casting is an alternative. Maybe a comment would be good in these places so
noone will lateron remove it again as it seems unneccessary to the 64bit-blind
automation/source/server/retstrm.hxx
- void GenReturn( USHORT nRet, SmartId aUId, ULONG nNr, String aString,
BOOL
bBool );
+ void GenReturn( USHORT nRet, SmartId aUId, sal_uInt32 nNr, String
aString,
BOOL bBool );
automation/source/server/sta_list.cxx
- pRet->GenReturn( RET_ProfileInfo, SmartId(
S_ProfileTime ),
pProfiler->GetPartitioningTime() );
+ pRet->GenReturn( RET_ProfileInfo, SmartId(
S_ProfileTime ),
comm_ULONG(pProfiler->GetPartitioningTime()) );
you should eather use comm_ULONG or sal_uInt32 but not mixed if possible
best would be to leave the comm_* types where they are used now and change the
USHORT and ULONG to the sal_* types
automation/source/testtool/cmdstrm.cxx
see above for using comm_* and sal_* types
by the way why are there only some ULONG and USHORT changed?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
