To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73550
User hro changed the following:
What |Old value |New value
================================================================================
Priority|P3 |P2
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Tue May 22 22:23:04 +0000
2007 -------
Raising priority to P2, there's much more broken due to the changes.
F.e. Disabling quickstarter in systray and reanebling it in office
Tool/Options/memory results in two (!!!) quickstarter icons in systray.
Deselecting quickstart load on startup in systray removes complete functionality
from systray menu.
Where is the code to remove the startmenu link ? Not only that you rewrote part
of the windows implementation, you removed some functionality, rearranged the
order of the functions/method so that a diff shows "everything new".
The complete logic on Windows is broken. God - this is really ugly.
And last but not least - the patch does not fix anything, it's complete nonsens
and changes nothing.
The windows are still destroyed by ShutdownIcon::SetAutostart().
(SetAutoStart() was intended to switch the autostart flag not to remove the
systray menu while OOo is running. And with your code it's not removed it's
still there but not working anymore).
What should the patch
if ( aExecuterWindow == NULL && aListenerWindow == NULL )
ShutdownIcon::terminateDesktop()
do in the WindowProc? The Windows are destroyed so this code will never be
reached !!!
This code is similar to
Foo:~Foo()
{
if (this == NULL )
delete this; // or do some other silly things
}
Guys - the complete logic is broken on Windows.
And the second fix is even worse. Beside that it actually changes nothing - it's
even worse it always destroys the executer window not just if the listener
window is still running.
The fix is like: "It's broken, now we ensure that it's broken even when it still
worked by luck".
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
