To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=74245
------- Additional comments from [EMAIL PROTECTED] Fri Apr 11 18:48:58 +0000
2008 -------
Hi Kohei,
I have some doubt about a detail of the latest patch. In
lcl_CompareMatrix2Query() this
if (rStr1 == rStr2)
return 0;
return rStr1 < rStr2 ? -1 : 1;
changed to
return rStr1.CompareIgnoreCaseToAscii(rStr2); // case-insensitive
As the method name says that works only for ASCII strings. To make that work
with Unicode, either collation or transliteration have to be used. As the
comparison is done in a binary search on data that is assumed to be sorted,
using ScGlobal::pCollator->compareString() should be appropriate.
lcl_CompareMatrix2Query() is also used in ScInterpreter::ScMatch(), I guess
there shouldn't be any negative impact by these changes, correct?
Thanks
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
