To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=90426
User pjanik changed the following:
What |Old value |New value
================================================================================
Issue type|DEFECT |PATCH
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Jun 23 15:58:21 +0000
2008 -------
Change for the first part:
diff -ur svtools.orig/source/contnr/fileview.cxx
svtools/source/contnr/fileview.cxx
--- svtools.orig/source/contnr/fileview.cxx 2008-06-23 17:14:54.000000000
+0200
+++ svtools/source/contnr/fileview.cxx 2008-06-23 17:23:03.000000000 +0200
@@ -681,11 +681,11 @@
OUString CreateExactSizeText_Impl( sal_Int64 nSize )
{
- double fSize( ( double ) nSize );
- int nDec;
+ double fSize( ( double ) nSize );
+ int nDec;
- ULONG nMega = 1024 * 1024;
- ULONG nGiga = nMega * 1024;
+ sal_Int64 nMega = 1024 * 1024;
+ sal_Int64 nGiga = nMega * 1024;
String aUnitStr = ' ';
Second part needs a closer look:
diff -ur svtools.orig/source/misc1/strmadpt.cxx
svtools/source/misc1/strmadpt.cxx
--- svtools.orig/source/misc1/strmadpt.cxx 2008-06-23 17:14:54.000000000
+0200
+++ svtools/source/misc1/strmadpt.cxx 2008-06-23 17:32:23.000000000 +0200
@@ -304,7 +304,7 @@
if (!m_xLockBytes.Is())
throw io::NotConnectedException();
if (nBytesToRead < 0
- || m_nPosition > std::numeric_limits< ULONG >::max()
+ || static_cast<ULONG>(m_nPosition) > std::numeric_limits< ULONG
>::max()
&& nBytesToRead > 0)
throw io::IOException();
rData.realloc(nBytesToRead);
@@ -335,7 +335,7 @@
{
if (!m_xLockBytes.Is())
throw io::NotConnectedException();
- if (m_nPosition > std::numeric_limits< ULONG >::max()
+ if (static_cast<ULONG>(m_nPosition) > std::numeric_limits< ULONG
>::max()
&& nMaxBytesToRead > 0)
throw io::IOException();
rData.realloc(nMaxBytesToRead);
@@ -384,7 +384,7 @@
SvLockBytesStat aStat;
if (m_xLockBytes->Stat(&aStat, SVSTATFLAG_DEFAULT) != ERRCODE_NONE)
throw io::IOException();
- return aStat.nSize <= m_nPosition ?
+ return aStat.nSize <= static_cast<ULONG>(m_nPosition) ?
0 :
std::min< sal_uInt32 >(
sal_uInt32(aStat.nSize - m_nPosition),
@@ -581,7 +581,7 @@
if (m_xSeekable.is())
try
{
- sal_Int64 nLength =
m_xSeekable->getLength();
+ sal_uInt64 nLength =
m_xSeekable->getLength();
if (nLength <
STREAM_SEEK_TO_END)
{
m_nSeekedFrom = Tell();
Please review.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
