To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=60594
------- Additional comments from [EMAIL PROTECTED] Wed Sep 17 07:37:49 +0000 2008 ------- fme->hennerdrewes: Thanks again for your patch. I had a closer look at the Writer stuff. Here are some comments: 1. The invalidation of kashidas has to be done per portion. Image this case: The line starts with one huge Arabic character, the font of which reports a minimum kashida width of 4000 twips. Then the kashida positions in the line are all marked as invalid, although the portion which requires the 4000 twips does not even have a kashida position. 2. I think using a sorted array (or a more 'modern' data structure like std::set) is more suitable for the kashida array, since right now IsKashidaInvalid/ClearKashidaInvalid always have to iterate the whole array. 3. if for some mysterious reason if(rSI.MarkKashidaInvalid(aItr.GetStart(), aItr.GetLength()) fails, we have an infinite loop in itradj.cxx. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
