To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96113
Issue #|96113
Summary|sw: ambiguous && ||
Component|Word processor
Version|DEV300m35
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|ama
Reported by|cmc
------- Additional comments from [EMAIL PROTECTED] Tue Nov 11 16:58:36 +0000
2008 -------
in
sw/source/ui/utlui/navipi.cxx
we have...
if(aTmpParentSize.Width() < aMinSize.Width() ||
aTmpParentSize.Height() < aMinSize.Height() &&
((SfxDockingWindow*)pParent)->GetFloatingWindow() &&
!((SfxDockingWindow*)pParent)->GetFloatingWindow()->IsRollUp())
which means (after expanding operator precedence)
if (
aTmpParentSize.Width() < aMinSize.Width() ||
(
aTmpParentSize.Height() < aMinSize.Height() &&
((SfxDockingWindow*)pParent)->GetFloatingWindow() &&
!((SfxDockingWindow*)pParent)->GetFloatingWindow()->IsRollUp()
)
)
is that really what we want ?, if so then patch A makes that explicit
or do we really want
if (
(
aTmpParentSize.Width() < aMinSize.Width() ||
aTmpParentSize.Height() < aMinSize.Height()
) &&
((SfxDockingWindow*)pParent)->GetFloatingWindow() &&
!((SfxDockingWindow*)pParent)->GetFloatingWindow()->IsRollUp()
)
which is not what we do now, but might be our intention, in which case
attachment 2 makes that explicit
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
