To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96970
                 Issue #|96970
                 Summary|extensions: plugin: some fixes
               Component|utilities
                 Version|DEV300m37
                Platform|All
                     URL|
              OS/Version|Linux
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|code
             Assigned to|pl
             Reported by|cmc





------- Additional comments from [EMAIL PROTECTED] Sat Dec  6 16:30:13 +0000 
2008 -------
Couple of things post-"swffix". Seeing as it now works, it reveals a few
problems that always been there.

Small new things, in a system-mozilla case pkgconfig gets included twice, (there
an include hidden in plugin/util/makefile.pmk. A sub-patch to use += on
PKGCONFIG_MODULES makes it build though it still warns, not really sure what the
"right thing" is there. Probably needs as master build-fix on the 3.0.1 tree.
(Same probably holds for the cast at gtk_plug_new for 64bit platforms)

Real meat is

a) in npnapi.cxx where we always pass address to Transact, but we forget to do
this in two arguments which crashes on some plugins for me.

b) mixing of "int" and size_t arguments to a ... ellipse thing which expects
ULONGS. Fine on 32bit, for 64bit they're different sizes and some things blow
up. I reckon that's the minimal patch to make it "just work"

c) and finally from npapi.h we're getting uint32 which are "unsigned long",
which breaks things the other direction. ifdefs in plugcon.hxx fix that

Sticking the whole bundle in on top of workspace swffix (and with some fixes to
e.g. the totem mozilla plugin itself), then I get working totem-based mozilla
plugins on x86_64

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to