To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96970


User pl changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'mh'
--------------------------------------------------------------------------------
             Assigned to|pl                        |cmc
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Mon Dec  8 17:43:10 +0000 
2008 -------
patch looks good apart from 2 things:

- first the double cast in 
pInst->pGtkWindow = gtk_plug_new((GdkNativeWindow)(sal_uIntPtr)pWindow->window);

didn't work for me (was my first try, but somehow the compiler still complained
about casting losing precision). However there is already a solution for that in
DEV300m37 as well as in OOO300m13

pInst->pGtkWindow =
gtk_plug_new((GdkNativeWindow)reinterpret_cast<sal_uIntPtr>(pWindow->window));

I guess there must be different compiler versions at work here because to my
unitiated eye these look pretty much same.

- the changes for LP64 (typedef-ing uint32 and such) belongs by right into the
npapi.h header from np_sdk since these types are definitions of the NP plugin 
API.

rene,mh: sure about the 3.0.1 target ?

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to