To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99010
------- Additional comments from [email protected] Mon Feb 9 14:10:32 +0000 2009 ------- cd->fs: Indeed this class is DLL_PUBLIC which is very awful. Currently there is no external project which use this class and therefore I would propose to make this class private to the toolkit project. No need to make this IMPLEMENTATION base class public. cd->fs: You're right that the evaluation of the member should be done in the base class. That's a problem with a quick look over the patch. As I have written above this VCLXTopWindow_Base must be made private to the project. There is no real advantage to make base implementation classes public to other projects if they are not intended for public use. We only suffer from too many exported symbols and limited changes in the toolkit project. In the mid-term I would like to see no implementation classes exported to other projects. The toolkit project should only be accessed by UNO interfaces/services. Base classes for other projects should be moved to a different library, e.g. vclunohelper. cd->fs: There are several problems with the ownership of objects in the toolkit. I would propose to make the VCLTopWindow window owner of a menu whenever it's set via setMenuBar(). The VCLTopWindow should held a reference to the menu so the menu cannot be destroyed as long as the VCLXTopWindow lives. Setting a new menu or an empty reference destroys the old toolkit based menu. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
