To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99010
------- Additional comments from [email protected] Wed Feb 18 10:39:02 +0000 2009 ------- > didn't see any action here for quite some time .... sorry for the delay; before answering I wanted to test (==debug) some more things, but as my holidays came to an end, I only had the weekends for this task. > cd->fs: As far as I know Ariel is working on a new version of the patch yes I am. I tried to follow Frank's comments, see below on that > cd->arielch: Do you know when you have a new version of the patch ready? I can assure next Monday. If it's too late, let me know. I'm trying the following in the new patch: * make VCLXTopWindow_Base class private to the toolkit project (as suggested by cd). Only class inheriting from it is layoutimpl::VCLXDialog (http://svn.services.openoffice.org/opengrok/xref/DEV300_m41/toolkit/source/awt/vclxdialog.hxx#48) * make the member m_bHasAWTMenuBar private * evaluate it in a protected and non virtual function in VCLXTopWindow_Base::cleanUpMenuBar. If I understood clearly, this is what Frank suggests: > The proper solution here is to introduce a "dispose" method at the > VCLXTopWindow_Base class, and make sure that all existing derived classes > call this method in their own dispose call (and leave a comment for future > derived classes) If I understand, you are not suggesting to inherit VCLXTopWindow_Base from css.lang.XComponent, but to add a function to do the job. * call this method in all existing derived class's dispose(). ToDo: add it to layoutimpl::VCLXDialog::dispose() [ http://svn.services.openoffice.org/opengrok/xref/DEV300_m41/toolkit/source/awt/vclxdialog.cxx#106 ], and test it. I attached a new patch, not fully tested/debugged yet. I'll do so on next weekend. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
