To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105835
User b_michaelsen changed the following:
What |Old value |New value
================================================================================
CC|'fl,fma,of,oj' |'fl,fma,fs,mav,of'
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Tue Oct 13
18:48:29 +0000 2009 -------
Ok, The Improvement program itself is _not_ broken. Logging works.
However, if the logfile (which is open for writing logdata) gets opened (via a
normal file-url dispatch), strange things happen:
- The file show up as having some weird binary content in OOo. However, when
looking at the file with other tools (stat, cat, vim) the file shows up as
empty (as expected).
- When the loaded document (however it was imported) gets open, OOo _writes_
binary garbage into the logfile. This is without ever notifying the user that
data is changed in the filesystem.
So, as long as the data is not being looked at with OOo while logging,
everything works. All this was tested with the latest fixes for the new buffered
IO introduced with mhu20.
Further investigation showed the following root causes:
- Premature optimization in comphelper::UiEventslogger
and logging::FileHandler skip flushing because they expect
osl::File to be unbuffered. Currently nothing calls
logging::FileHandler::flush().
@fs: Should logging::FileHandler::publish() do so, or is this
client expected to explicitly call flush() on the FileHandler?
- This leaves the logfile as an empty (zero byte) file.
- OOo inappropriately handles zero byte files. If one clicks File->Open
it shows an import dialog. Even if one presses "Cancel" the file gets
overridden (with binary garbage/likely an empty storage). The same happens
when the file is opened and closed (_without_ saving).
Opening the file read-only fixes this for the usage tracking, but the issue
is serious enough in itself.
@mav: Please have a look.
removing oj from cc as this is indeed not related to cws oj18.
Adding mav to cc because of opening empty files issue.
Adding fs to cc because of flush issue in logging::FileHandler.
Should we separate the issues?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
