To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835
------- Additional comments from [email protected] Wed Oct 14 12:16:36 +0000 2009 ------- fs->b_michaelsen: sorry for the delay ... I'm somewhat undecided with respect to "flush". Given that you say nobody currently calls XLogHandler::flush, it might be a good idea to add this to the publish call, just to catch the other occurrences where logger clients forgot the flush. On the other hand, it'd be somewhat hacky, as it would render XLogHandler::flush useless (it's effectively a no-op then). Given that the only existing client for XLogHandler::publish currently is the Logger implementation itself (http://svn.services.openoffice.org/opengrok/xref/Current%20%28trunk%29/extensions/source/logging/logger.cxx#224), I tend to think that EventLogger::impl_ts_logEvent_nothrow should not only call "publish" at each handler, but also "flush". This way, it could be considered an implementation detail of the Logger implementation that publishing a record also means flushing all handlers where it was logged to. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
